feat: allow disabling pod locality in xDS #10404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this means destination rules won't work correctly; but things like VMs and other WorkloadEntries based workloads will. This is not documented as it is meant as a temporary hotfix, with a durable fix for supporting WorkloadEntries coming later.
|
Issues linked to changelog: |
|
Visit the preview URL for this PR (updated for commit b9d49b2): https://gloo-edge--pr10404-yuval-k-disable-loca-whog6nen.web.app (expires Tue, 03 Dec 2024 00:27:21 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 77c2b86e287749579b7ff9cadb81e099042ef677 |
shashankram
approved these changes
Nov 25, 2024
lgadban
reviewed
Nov 25, 2024
shashankram
reviewed
Nov 25, 2024
shashankram
approved these changes
Nov 26, 2024
lgadban
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When this is enabled - it means destination rules won't work correctly; but things like VMs and other WorkloadEntries based workloads will. This is not documented as it is meant as a temporary hotfix, with a durable fix for supporting WorkloadEntries coming later.
to enable, set DISABLE_POD_LOCALITY_XDS to true in the gloo deployment.
BOT NOTES:
resolves https://github.com/solo-io/solo-projects/issues/7302