test fix: allow test scenarios run more than one time #10395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting the logger in controller runtime only works for the first time, and is no-op the second time. this means that the second time the test runs it will run to a testing.T that finished running. The fix is to changing the underlying log writer, so we can swap up the testing.T to the current one
sam-heilbron
approved these changes
Nov 22, 2024
| func NewTestLogger(t *testing.T) *zap.Logger { | ||
| writer := &testingWriter{t: t} | ||
| func NewTestLogger() *zap.Logger { | ||
| //writer := &testingWriter{t: t} |
There was a problem hiding this comment.
nit: can we delete?
also the comment on the constructor is now out of date, since it references testing.T
|
/skip-changelog |
|
/skipCI-kube-tests:true |
stevenctl
approved these changes
Nov 22, 2024
|
Visit the preview URL for this PR (updated for commit a2f62ce): https://gloo-edge--pr10395-yuval-k-setup-test-s-8ce4wug3.web.app (expires Tue, 03 Dec 2024 16:59:40 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 77c2b86e287749579b7ff9cadb81e099042ef677 |
|
note: i still see the 0 listener flake; i can't repro locally... I added some more logs in this PR, so next it happens in CI we will have more to go on |
|
/skip-changelog |
|
/skip-changelog |
|
/skip-changelog |
|
/skip-changelog |
|
/skip-changelog |
sam-heilbron
approved these changes
Nov 26, 2024
|
/skip-changelog |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting the logger in controller runtime only works for the first time, and is no-op the second time. this means that the second time the test runs it will run to a testing.T that finished running.
The fix is to changing the underlying log writer, so we can swap up the testing.T to the current one