forked from kgateway-dev/kgateway
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't export ValidationSplitWebhook test #10394
Merged
Merged
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
a0c6a06
changes
sheidkamp a910a28
Update validation_strict_tests.go
sheidkamp d92c6cd
Update validation_strict_tests.go
sheidkamp cbf6a8c
Merge branch 'main' into sheidkamp/dont-export-split-validation-test
sheidkamp 7a033c1
Merge branch 'main' into sheidkamp/dont-export-split-validation-test
sam-heilbron 485aa03
Update test naming so dependencies don't need to change
sheidkamp 060d445
Merge branch 'main' into sheidkamp/dont-export-split-validation-test
sheidkamp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
changelog: | ||
- type: NON_USER_FACING | ||
issueLink: https://github.com/solo-io/solo-projects/issues/7256 | ||
resolvesIssue: false | ||
description: >- | ||
Create a new SuiteRunner for the ValidationTests which does not include the split validation test, which | ||
fails when imported by other projects. https://github.com/k8sgateway/k8sgateway/issues/10374 created to | ||
track a fix that will allow tests that update Helm values to be exported. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not leave the exported one
ValidationStrictSuiteRunner
so s-p import doesn't need to change?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and the new one can be
ValidationStrictSuiteRunnerNotExported
or something?