js-legacy: Fix decoding when optional authority is not provided #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joncinque
changed the title
joncinque
reviewed
Jan 14, 2025
There was a problem hiding this comment.
Sorry, but I don't think this is the right approach unfortunately. buffer-layout has a method for showing that a type must use a concrete instance in order to determine the layout size, which is by overriding getSpan. We've done something incorrect by not returning an error from getSpan for COptionPublicKeyLayout.
I tried to do the full fix at #71 -- will that fix your issue?
Comment on lines
+43
to
+45
| return option === 0 ? COptionPublicKeyLayout.spanWhenNull : 1 + COptionPublicKeyLayout.spanWithValue; | ||
| } | ||
| return 1 + this.publicKeyLayout.span; | ||
| return 1 + COptionPublicKeyLayout.spanWithValue; |
There was a problem hiding this comment.
These are incorrect since spanWithValue already includes the additional byte
|
Closing since this was fixed with #71 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@joncinque This PR fixes #68 only for Token 2022 (this repo). The original issue solana-labs#7549 actually affects Token 2022 and SPL Token contract.