web3.js: remove Buffer from PublicKeyInitData

[macalinao]

Problem

Removes a redundant Buffer declaration

Addresses solana-labs/solana-web3.js#1100.

[steveluscher]

Once something is added to the public interface, it's very difficult to remove. In particular, if anyone tries to pass a Buffer into the PublicKey constructor, this change will make Typescript newly fail on their project.

Thoughts on that?

Pull request has been modified.

[macalinao]

Once something is added to the public interface, it's very difficult to remove. In particular, if anyone tries to pass a Buffer into the PublicKey constructor, this change will make Typescript newly fail on their project.

Thoughts on that?

This is not true because Buffer implements Uint8Array

[steveluscher]

Right! I had that backwards; you're right.

const buffer: Buffer = null as any;
function takesAUint8Array(thing: Uint8Array) {}
takesAUint8Array(buffer); // OK

const byteArray: Uint8Array = null as any;
function takesABuffer(thing: Buffer) {}
takesABuffer(byteArray); // ERROR

[macalinao]

Finally my first PR into Solana core!! :D thank you