This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
refactor(experimental): codecs: use bigint for range values on u64 and u128
#2201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 27, 2024
This was referenced Feb 27, 2024
lorisleiva
approved these changes
Feb 27, 2024
buffalojoec
force-pushed
the
02-26-refactor_experimental_codecs_refactor_message_out_of_codec_assertions
branch
from
77036c6 to
36c7253
Compare
buffalojoec
force-pushed
the
02-27-refactor_experimental_codecs_use_bigint_for_range_values_on_u64_and_u128_
branch
from
6f0e341 to
692c164
Compare
This was referenced Feb 28, 2024
steveluscher
force-pushed
the
02-26-refactor_experimental_codecs_refactor_message_out_of_codec_assertions
branch
from
36c7253 to
c091204
Compare
steveluscher
force-pushed
the
02-27-refactor_experimental_codecs_use_bigint_for_range_values_on_u64_and_u128_
branch
from
692c164 to
1a20e1f
Compare
Merge activity
|
steveluscher
force-pushed
the
02-26-refactor_experimental_codecs_refactor_message_out_of_codec_assertions
branch
from
c091204 to
1e1c3e2
Compare
Base automatically changed from
02-26-refactor_experimental_codecs_refactor_message_out_of_codec_assertions
to
master
February 29, 2024 19:43
steveluscher
force-pushed
the
02-27-refactor_experimental_codecs_use_bigint_for_range_values_on_u64_and_u128_
branch
from
1a20e1f to
0ae2707
Compare
steveluscher
deleted the
02-27-refactor_experimental_codecs_use_bigint_for_range_values_on_u64_and_u128_
branch
|
🎉 This PR is included in version 1.90.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working with
u64andu128codecs, all range numerical values should bebigint, since they are large, >8 byte numbers.Simply flips the minimum range boundary to use
bigint, for consistency.