Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

refactor(experimental): errors: codecs-strings package #2192

Merged
merged 1 commit into from
Feb 29, 2024
Merged

refactor(experimental): errors: codecs-strings package #2192

merged 1 commit into from
Feb 29, 2024

Conversation

buffalojoec
Copy link
Contributor

Adds custom SolanaError throws to the @solana/codecs-strings package.

This was referenced Feb 24, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@buffalojoec Graphite App
Copy link
Contributor Author

buffalojoec commented Feb 24, 2024 •
edited
Loading

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@buffalojoec buffalojoec mentioned this pull request Feb 24, 2024
Merged
@mergify mergify bot added the community label Feb 24, 2024
@buffalojoec buffalojoec force-pushed the 02-24-refactor_experimental_errors_codecs-numbers_package branch from ed22aa7 to 5e11410 Compare February 24, 2024 21:10
@buffalojoec buffalojoec force-pushed the 02-24-refactor_experimental_errors_codecs-strings_package branch from 6c443e5 to 4d78436 Compare February 24, 2024 21:10
steveluscher
steveluscher suggested changes Feb 26, 2024
View reviewed changes
Copy link
Contributor

@steveluscher steveluscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added via Giphy

@steveluscher steveluscher linked an issue Feb 26, 2024 that may be closed by this pull request
[experimental] Convert all thrown errors to SolanaError #2118
Closed
@buffalojoec buffalojoec force-pushed the 02-24-refactor_experimental_errors_codecs-numbers_package branch from 5e11410 to f9897b1 Compare February 27, 2024 07:32
This was referenced Feb 27, 2024
Merged
Merged
@buffalojoec buffalojoec force-pushed the 02-24-refactor_experimental_errors_codecs-strings_package branch from 4d78436 to d466b34 Compare February 27, 2024 07:32
@buffalojoec buffalojoec mentioned this pull request Feb 27, 2024
Merged
@lorisleiva lorisleiva mentioned this pull request Feb 27, 2024
Closed
steveluscher
steveluscher approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@steveluscher steveluscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added via Giphy

packages/errors/src/messages.ts Outdated Show resolved Hide resolved
@buffalojoec buffalojoec force-pushed the 02-24-refactor_experimental_errors_codecs-numbers_package branch from f9897b1 to b8479fc Compare February 28, 2024 16:30
@buffalojoec buffalojoec force-pushed the 02-24-refactor_experimental_errors_codecs-strings_package branch from d466b34 to 128710c Compare February 28, 2024 16:31
@steveluscher steveluscher force-pushed the 02-24-refactor_experimental_errors_codecs-numbers_package branch from b8479fc to 42b6bf4 Compare February 29, 2024 19:28
@steveluscher steveluscher force-pushed the 02-24-refactor_experimental_errors_codecs-strings_package branch from 128710c to 75df51c Compare February 29, 2024 19:28
@steveluscher
Copy link
Contributor

steveluscher commented Feb 29, 2024 •
edited
Loading

Merge activity

  • Feb 29, 11:33 AM PST: @steveluscher started a stack merge that includes this pull request via Graphite.
  • Feb 29, 11:52 AM PST: Graphite rebased this pull request as part of a merge.
  • Feb 29, 11:53 AM PST: @steveluscher merged this pull request with Graphite.

@steveluscher steveluscher force-pushed the 02-24-refactor_experimental_errors_codecs-numbers_package branch from 42b6bf4 to 27bf3a2 Compare February 29, 2024 19:49
Base automatically changed from 02-24-refactor_experimental_errors_codecs-numbers_package to master February 29, 2024 19:51
@steveluscher steveluscher force-pushed the 02-24-refactor_experimental_errors_codecs-strings_package branch from 75df51c to 0e91f7c Compare February 29, 2024 19:51
@steveluscher steveluscher merged commit 91a360d into master Feb 29, 2024
5 of 7 checks passed
@steveluscher steveluscher deleted the 02-24-refactor_experimental_errors_codecs-strings_package branch February 29, 2024 19:53
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 2, 2024

🎉 This PR is included in version 1.90.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions GitHub Actions
Copy link
Contributor

Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@steveluscher steveluscher steveluscher approved these changes

@lorisleiva lorisleiva Awaiting requested review from lorisleiva

Assignees
No one assigned
Labels
community released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[experimental] Convert all thrown errors to SolanaError
3 participants
@buffalojoec @steveluscher @lorisleiva