Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

Incomplete Error Handling in sendEncodedTransaction #3561

Closed
paur94 opened this issue Nov 13, 2024 · 3 comments
Closed

Incomplete Error Handling in sendEncodedTransaction #3561

paur94 opened this issue Nov 13, 2024 · 3 comments
Labels
invalid This doesn't seem right

Comments

@paur94
Copy link

paur94 commented Nov 13, 2024

The sendEncodedTransaction function’s error handling is incomplete, missing essential fields like name, error code. This omission prevents the isSolanaError check from working as intended, limiting error traceability and debugging.
@paur94 paur94 added the bug Something isn't working label Nov 13, 2024
@steveluscher
Copy link
Contributor

Can you go into more detail here? isSolanaError() is from the v2.x line, and sendEncodedTransaction() is from the v1.x line, so those are not designed to work together.

What are you trying to do, what's happening, and what did you expect to happen?

@steveluscher steveluscher added invalid This doesn't seem right and removed bug Something isn't working labels Nov 13, 2024
@steveluscher
Copy link
Contributor

Feel free to reopen this with more detail when you have time.

@steveluscher steveluscher closed this as not planned Won't fix, can't repro, duplicate, stale Dec 2, 2024
@steveluscher steveluscher mentioned this issue Dec 3, 2024
Closed
@github-actions GitHub Actions
Copy link
Contributor

Because there has been no activity on this issue for 7 days since it was closed, it has been automatically locked. Please open a new issue if it requires a follow up.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@steveluscher @paur94