Merge pull request #148 from social-native/feat/track-total-hits

Add track_total_hits
social-native · May 28, 2021 · a21862c · a21862c
2 parents 5ea0ff5 + 95370f4
commit a21862c
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 6 deletions.
diff --git a/__tests__/integration/filters/set_filter.test.ts b/__tests__/integration/filters/set_filter.test.ts
@@ -19,7 +19,8 @@ describe('Filters', () => {
                 query: {bool: {should: [{term: {boolean_field: true}}]}},
                 size: 10,
                 sort: ['_score', '_doc'],
-                track_scores: true
+                track_scores: true,
+                track_total_hits: true
             });
         });
 

diff --git a/__tests__/integration/manager/set_user_state.test.ts b/__tests__/integration/manager/set_user_state.test.ts
@@ -31,7 +31,8 @@ describe('Manager', () => {
                     query: {bool: {should: [{exists: {field: fakeField}}]}},
                     size: 10,
                     sort: ['_score', '_doc'],
-                    track_scores: true
+                    track_scores: true,
+                    track_total_hits: true,
                 });
             });
         });
@@ -65,7 +66,8 @@ describe('Manager', () => {
                     query: {bool: {should: [{exists: {field: fakeBooleanField}}]}},
                     size: 10,
                     sort: ['_score', '_doc'],
-                    track_scores: true
+                    track_scores: true,
+                    track_total_hits: true,
                 });
             });
 
@@ -79,7 +81,8 @@ describe('Manager', () => {
                     query: {bool: {must: [{range: {[fakeRangeField]: {gt: 0, lt: 100}}}]}},
                     size: 10,
                     sort: ['_score', '_doc'],
-                    track_scores: true
+                    track_scores: true,
+                    track_total_hits: true
                 });
             });
         });

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
     "name": "elastic-composer",
-    "version": "4.7.0",
+    "version": "4.7.1",
     "description": "",
     "main": "dist/index.cjs.js",
     "module": "dist/index.es.js",

diff --git a/src/manager.ts b/src/manager.ts
@@ -1384,7 +1384,7 @@ class Manager<
         // pageSize param can be used to override the default page size
         pageSize: number | undefined = undefined
     ): ESRequest => {
-        return {...request, size: pageSize || this.pageSize, track_scores: true};
+        return {...request, size: pageSize || this.pageSize, track_scores: true, track_total_hits: true};
     };
 
     public _addSortToQuery = (request: ESRequest): ESRequest => {

diff --git a/src/types.ts b/src/types.ts
@@ -34,6 +34,7 @@ export type ESRequest = {
     from?: number;
     size?: number;
     track_scores?: boolean;
+    track_total_hits?: boolean;
     sort?: ESRequestSortField;
     search_after?: ESRequestSortField;
 };