Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow cool off between import-projects tests for cleanup #499

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

cchirac-snyk
Copy link
Contributor

@cchirac-snyk cchirac-snyk commented Feb 6, 2025

  • Tests written and linted
  • Documentation written in Wiki/README
  • Commit history is tidy & follows Contributing guidelines ℹ︎

What this does

The tests are currently failing the pipeline, and it looks like individual tests are affecting each other - when running each failing test in isolation, they pass. Although it's not clear how they affect each other, a longer cool off period between the import-projects tests allows them enough time to do whatever cleanup needs to happen remotely, thus fixing the tests.

Notes for the reviewer

Hide whitespaces when reviewing, as the diff is actually a lot smaller.

More information

Screenshots

Visuals that may help the reviewer

@cchirac-snyk cchirac-snyk requested a review from a team as a code owner February 6, 2025 16:37
@cchirac-snyk cchirac-snyk merged commit db70d73 into master Feb 10, 2025
6 checks passed
@cchirac-snyk cchirac-snyk deleted the fix/tests branch February 10, 2025 10:45
@team-import
Copy link
Collaborator

🎉 This PR is included in version 2.21.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants