Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the default log level to "INFO" #148

Open
BECATRUE opened this issue Sep 18, 2023 · 2 comments
Open

Update the default log level to "INFO" #148

BECATRUE opened this issue Sep 18, 2023 · 2 comments
Assignees
Labels
enhancement New feature or any improvements to codes

Comments

@BECATRUE
Copy link
Member

BECATRUE commented Sep 18, 2023

Feature you want to implement

A user seems to use the logger app to check if the submission runs well.

So I think updating the default log level from "WARNING" to "INFO" is more efficient as the submission log level is "INFO".

@BECATRUE BECATRUE added the enhancement New feature or any improvements to codes label Sep 18, 2023
@BECATRUE BECATRUE self-assigned this Sep 18, 2023
@BECATRUE
Copy link
Member Author

How about your opinion? @kangz12345

@kangz12345
Copy link
Member

I think it is a matter of taste. For now, we are not quite sure of our system's stability, so "INFO" level logs are very informative. However, later they might seem too verbose.
So I suggest passing the default log levels (for both GUI and file) to the logger app constructor, so we can give them in the config file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or any improvements to codes
Projects
Status: No status
Development

No branches or pull requests

2 participants