Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add structured type support for hybrid tables #572

Merged
merged 3 commits into from
Jan 13, 2025

Conversation

sfc-gh-jvasquezrojas
Copy link
Collaborator

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding new credentials
    • I am adding a new dependency
  3. Please describe how your code solves the related issue.

Original PR
Co-authored by benvdh-incentro

@sfc-gh-jvasquezrojas sfc-gh-jvasquezrojas requested a review from a team as a code owner January 13, 2025 15:33
@benvdh-incentro
Copy link

benvdh-incentro commented Jan 13, 2025

@sfc-gh-jvasquezrojas thx for adding the tests, and the first review. Now that all checks have passed and the code had a second review, what will be the next step? Merging?

@sfc-gh-lcalderonachio thx for the second review!

@sfc-gh-jvasquezrojas sfc-gh-jvasquezrojas merged commit 6a9ac4d into main Jan 13, 2025
47 checks passed
@sfc-gh-jvasquezrojas sfc-gh-jvasquezrojas deleted the jvasquezrojas/array-column-not-supported branch January 13, 2025 18:22
@github-actions github-actions bot locked and limited conversation to collaborators Jan 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ARRAY column not supported on HybridTable despite Snowflake documentation claiming otherwise
3 participants