Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove create-session-mode header for internally used CreateSession API in S3 Express #3992

Merged
merged 2 commits into from
Jan 31, 2025

Conversation

ysaito1001
Copy link
Contributor

@ysaito1001 ysaito1001 commented Jan 31, 2025

Motivation and Context

This PR stops populating SessionMode by default for the CreateSession API internally used by S3 Express, as the value already matched the service-side default and it was already not sent by other SDKs.

Testing

  • Existing tests in CI (i.e. canary)
  • Updated S3 Express integration tests to verify that no SessionMode header is present by the CreateSession API internally used by S3 Express

Checklist

  • For changes to the AWS SDK, generated SDK code, or SDK runtime crates, I have created a changelog entry Markdown file in the .changelog directory, specifying "aws-sdk-rust" in the applies_to key.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

A new generated diff is ready to view.

  • AWS SDK (ignoring whitespace)
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python
  • No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

@ysaito1001 ysaito1001 marked this pull request as ready for review January 31, 2025 16:38
@ysaito1001 ysaito1001 requested review from a team as code owners January 31, 2025 16:38
Copy link

A new generated diff is ready to view.

  • AWS SDK (ignoring whitespace)
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python
  • No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

Copy link
Contributor

@landonxjames landonxjames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ysaito1001 ysaito1001 added this pull request to the merge queue Jan 31, 2025
Merged via the queue into main with commit c91bc77 Jan 31, 2025
42 of 44 checks passed
@ysaito1001 ysaito1001 deleted the ysaito/remove-create-session-mode-header branch January 31, 2025 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants