Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude transfer-encoding header from sigv4(a) signing #3991

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

landonxjames
Copy link
Contributor

Add changelog

Motivation and Context

Exclude transfer-encoding header from sigv4(a) signing. It is a hop by hop header and can be erased or modified by a proxy (in our particular case Cloudfront)

Description

Testing

Updated the existing tests for excluded headers.

Checklist

  • For changes to the AWS SDK, generated SDK code, or SDK runtime crates, I have created a changelog entry Markdown file in the .changelog directory, specifying "aws-sdk-rust" in the applies_to key.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@ysaito1001 ysaito1001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Existing integration tests for S3 capture the transfer-encoding header but I suspect they won't be broken since the way they verify expected results in tests is resilient to the changes in PR.

I am ok with leaving the transfer-encoding in connection recording tests; if we can create an issue for cleanup, that'd be great but keeping it around wouldn't be a blocker (please ignore that since the transfer-encoding in connection recording tests only appear in responses). Maybe want to quickly check (e.g., by using capture_request) that the transfer-encoding header is indeed excluded from an outgoing request.

Copy link

A new generated diff is ready to view.

  • AWS SDK (ignoring whitespace)
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python
  • No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

@landonxjames
Copy link
Contributor Author

Existing integration tests for S3 capture the transfer-encoding header but I suspect they won't be broken since the way they verify expected results in tests is resilient to the changes in PR.

Looks like all of those should be able to stay since all of them appear in a Response and this change only impacts request signing. None of the SignedHeaders values reference transfer-encoding

@landonxjames landonxjames marked this pull request as ready for review January 29, 2025 23:00
@landonxjames landonxjames requested review from a team as code owners January 29, 2025 23:00
@landonxjames landonxjames added this pull request to the merge queue Jan 29, 2025
Merged via the queue into main with commit c0b5ee3 Jan 29, 2025
42 of 44 checks passed
@landonxjames landonxjames deleted the landonxjames/transfer-encoding-signing branch January 29, 2025 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants