Only output dev preview warning messages for 0.x versions #3219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcoh
reviewed
Nov 16, 2023
aws/SDK_README.md.hb
Outdated
|
|
||
| The SDK is code generated from [Smithy models](https://awslabs.github.io/smithy/) that represent each AWS service. The code used to generate the SDK can be found in [smithy-rs](https://github.com/smithy-lang/smithy-rs). | ||
| The SDK is code generated from [Smithy models](https://awslabs.github.io/smithy/) that represent each AWS service. |
There was a problem hiding this comment.
to avoid conflicts, change this link to smithy-lang
| includeHeader: Boolean, | ||
| includeLicense: Boolean, | ||
| asComments: Boolean, | ||
| ): Writable = writable { | ||
| val moduleName = codegenContext.settings.moduleName | ||
| val stableVersion = !codegenContext.settings.moduleVersion.startsWith("0.") |
There was a problem hiding this comment.
do we want to assert it does start with a number or something? I'm 99% it's never v... but I wouldn't want to accidentally ship 1.0 in case it did.
rcoh
approved these changes
Nov 16, 2023
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
rcoh
approved these changes
Nov 16, 2023
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
jdisanti
commented
Nov 17, 2023
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.