Constant time comparison for SigV4a #3174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniele Ahmed <ahmeddan@amazon.de>
jdisanti
reviewed
Nov 10, 2023
| let d = Zeroizing::new(pk.to_bytes_be().1); | ||
| break SigningKey::from_bytes(&d).unwrap(); | ||
| if k0 <= BIG_N_MINUS_2 { | ||
| let pk = k0.checked_add(&U256::ONE).unwrap_or(U256::ZERO); |
There was a problem hiding this comment.
This seems like it might be a change in behavior. What was the behavior for the + operator previously?
There was a problem hiding this comment.
It's not a change in behavior. k0 + 1 is computed when k0 <= BIG_N_MINUS_2, and BIG_N_MINUS_2 < U256::MAX. I can change the unwrap_or to expect too.
There was a problem hiding this comment.
I think an expect with the reasoning above would be clearer.
|
We should rerun the sigv4a canary before merging this for sure |
Signed-off-by: Daniele Ahmed <ahmeddan@amazon.de>
Signed-off-by: Daniele Ahmed <ahmeddan@amazon.de>
Signed-off-by: Daniele Ahmed <ahmeddan@amazon.de>
Signed-off-by: Daniele Ahmed <ahmeddan@amazon.de>
Signed-off-by: Daniele Ahmed <ahmeddan@amazon.de>
rcoh
approved these changes
Nov 14, 2023
jdisanti
approved these changes
Nov 14, 2023
Signed-off-by: Daniele Ahmed <ahmeddan@amazon.de>
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3162
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.