Object Pooling #822
Merged
Object Pooling #822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added `using` directive for `MzLibUtil`. Introduced a static readonly `HashSetPool<int>` named `HashSetPool` to manage a pool of hash sets. Updated `DigestionAgent` constructor to initialize `HashSetPool`. Refactored `GetDigestionSiteIndices` to use a hash set from `HashSetPool` for storing indices, ensuring no duplicates. Explicitly added start and end of protein sequence as cleavage sites. Implemented `try-finally` block to return hash set to pool after use. Final list of indices is now sorted before returning.
nbollis
added
Maintenance
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #822 +/- ##
==========================================
+ Coverage 77.37% 77.41% +0.04%
==========================================
Files 220 223 +3
Lines 33197 33263 +66
Branches 3441 3444 +3
==========================================
+ Hits 25686 25752 +66
Misses 6939 6939
Partials 572 572
|
nbollis
requested review from
trishorts,
Alexander-Sol,
zhuoxinshi and
RayMSMS
RayMSMS
previously approved these changes
Jan 15, 2025
trishorts
previously approved these changes
Jan 15, 2025
Alexander-Sol
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Classification
New feature to improve performance by reducing memory allocations.
PR Summary
Introduced object pooling for
Dictionary,HashSet, andListinstances.DictionaryPool<TKey, TValue>,HashSetPool<T>, andListPool<T>classes in respective files.DigestionAgent.csto useHashSetPool<int>for poolingHashSetinstances.ObjectPoolTests.csfor the new pooling classes.