Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optional Digestion Count Output #2460
base: master
Are you sure you want to change the base?
Optional Digestion Count Output #2460
Changes from all commits
90b2ce5
f8bfbdb
83d956d
2cc25f6
ccdf5c9
7f5a2ad
3657dc6
7c33067
4429039
ffcd713
7c3e2ca
ca062ca
6d7471a
73bedd9
1cb8dfe
5d67fd4
7c58288
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you should call the lock inside the addOrUpdate method. That should be handled internally by the AddOrUpdate method
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is to ensure the internal lists are thread safe. This is needed otherwise unit test AddOrCreate_ThreadSafeWithDictionary fails.
Check warning on line 1958 in MetaMorpheus/TaskLayer/SearchTask/PostSearchAnalysisTask.cs
Codecov / codecov/patch
MetaMorpheus/TaskLayer/SearchTask/PostSearchAnalysisTask.cs#L1958
Check warning on line 1983 in MetaMorpheus/TaskLayer/SearchTask/PostSearchAnalysisTask.cs
Codecov / codecov/patch
MetaMorpheus/TaskLayer/SearchTask/PostSearchAnalysisTask.cs#L1983
Check warning on line 1993 in MetaMorpheus/TaskLayer/SearchTask/PostSearchAnalysisTask.cs
Codecov / codecov/patch
MetaMorpheus/TaskLayer/SearchTask/PostSearchAnalysisTask.cs#L1993