Analyte type #2434
Merged
Analyte type #2434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Updated to MzLib 1.0.548 and fixed custom ions in search tasks * reverted calibration task change * merged in master bbbyy * Enabled Library Loading from command line
Modified ResultsDictionary keys to use plural forms of analyte type labels by appending 's'. Updated status message for writing unique form results to use lowercase version of UniqueFormLabel.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2434 +/- ##
=======================================
Coverage 93.81% 93.82%
=======================================
Files 141 142 +1
Lines 21993 22008 +15
Branches 3014 3014
=======================================
+ Hits 20633 20648 +15
Misses 910 910
Partials 450 450
|
Modified ResultsDictionary keys to use plural forms of analyte type labels by appending 's'. Updated status message for writing unique form results to use lowercase version of UniqueFormLabel.
…into AnalyteType
trishorts
previously approved these changes
Nov 14, 2024
trishorts
approved these changes
Nov 14, 2024
avcarr2
approved these changes
Dec 12, 2024
acesnik
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced a new
AnalyteTypeclass to standardize analyte type handling and updated related classes and methods to use this new structure.EngineLayer/AnalyteType: Added new class to represent analyte types and their properties.GlobalVariables: Updated to useAnalyteTypeinstead of strings and modified initialization method.PostSearchAnalysisTask: Adjusted status messages and file naming conventions to useAnalyteTypeproperties.MetaMorpheusTask: SetAnalyteTypebased on protease name using the new method.AnalyteTypeobjects instead of strings.