-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Github Actions 1: Cross Platform Build #2398
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
started github actions
…MetaMorpheus into nbollis-patch-1
nbollis
changed the title
Github Actions: Cross Platform Build
Github Actions 1: Cross Platform Build
Aug 16, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2398 +/- ##
=======================================
Coverage 93.65% 93.65%
=======================================
Files 140 140
Lines 21896 21896
Branches 3005 3005
=======================================
Hits 20506 20506
Misses 934 934
Partials 456 456 |
@@ -377,7 +379,7 @@ public static void SpectralWriterTest() | |||
postSearchTask.Run(); | |||
|
|||
var libraryList = Directory.GetFiles(path, "*.*", SearchOption.AllDirectories); | |||
string updateLibraryPath = libraryList.First(p => p.Contains("SpectralLibrary") && !p.Contains(matchingvalue)).ToString(); | |||
string updateLibraryPath = libraryList.First(p => p.Contains("updateSpectralLibrary") && !p.Contains(matchingvalue)).ToString(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great change!
Alexander-Sol
approved these changes
Aug 21, 2024
trishorts
approved these changes
Aug 23, 2024
elaboy
approved these changes
Aug 23, 2024
Related issue for reference, #2088 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a github action that builds MetaMorpheus on Windows, Linux, and mac.
To build on windows and mac, a new configuration was generated that excluded the MetaMorphesusSetup and Project.wix Projects