[Ignore Coverage] #4 - Digestion params generalization #2341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into mzlibUpdate
…o new naming convention
…tionParameters. Toml Properties changed to make this work, all tests pass
nbollis
changed the title
nbollis
changed the title
nbollis
changed the title
|
wherein nic embraces the var side |
nbollis
changed the title
Alexander-Sol
approved these changes
Apr 19, 2024
elaboy
approved these changes
May 13, 2024
acesnik
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generalizes digestion parameters in common parameters to enable rna digestion and protein digestion.
In the task windows, I had to move all things dependent upon the digestion agent being a protease into an if clause that casts the IDigestionParams.DigestionAgent into a protease
Needed to improve code coverage so I found a few miscelaneous spots to do so. ModTypeForTreeViewModel and the Glyco Node class