-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Splitting Zitadel-rust project in sub crates #592
base: main
Are you sure you want to change the base?
Conversation
…claims, a user could set using Action
well i realise i dont pass some linting. Wonder if i should revert back to buf instead of trying to do it myself :-) i will amend this pr. Buf actually solve a couple of problems. Sorry |
Will look into it on the weekend ;) and yeah, buf has its perks ;) I learned that the hard way as well. |
One question that comes to mind: why use a third crate for examples? As far as I know in Rust people show examples inside the crate. Those are not compiled when the crate is downloaded right? |
no particular reason, i will move them back into the zitadel crate. |
you will have to exclude cargo clippy for the generated Tonic code. |
Hi there,
Major Changes, Possible Break
This PR is a first attempt to split the zitadel-rust crate into 3 crates :
the zitadel-gen could be renamed zitadel-sys or whatever, but it should basicaly hold the same version as the zitadel version where the proto files are extracted.
The zitadel:: is properly re-exported, so if should have no impacts on downstream users
Minor Changes :
zitadel crate :
the CI/CD needs probably be reviewed and fixed to be aligned if this PR is accepted
Don't be shy, if i wrote crappy code, just let me know :-)