From d7649ed829fa336bc60f481cf68f76289f35a9c3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mik=20M=C3=BCller?= <83001409+MikMuellerDev@users.noreply.github.com> Date: Fri, 25 Oct 2024 02:31:08 +0200 Subject: [PATCH] fix: Quick action errors and device reloads --- web/src/pages/dash/QuickActions/Action.svelte | 20 +++++++++++++++++-- web/src/pages/rooms/App.svelte | 6 ++++++ web/src/pages/rooms/Device.svelte | 2 ++ 3 files changed, 26 insertions(+), 2 deletions(-) diff --git a/web/src/pages/dash/QuickActions/Action.svelte b/web/src/pages/dash/QuickActions/Action.svelte index fdf51b0c..7825b66a 100644 --- a/web/src/pages/dash/QuickActions/Action.svelte +++ b/web/src/pages/dash/QuickActions/Action.svelte @@ -65,8 +65,14 @@ hmsExecutionResults = [ ...hmsExecutionResults, { - response: hmsRes, modeRun: true, + response: { + title: data.data.data.name, + success: hmsRes.success, + output: hmsRes.output, + fileContents: new Map(), + errors: hmsRes.errors, + }, }, ] } catch (err) { @@ -88,10 +94,20 @@ {/if} {#if hmsExecutionResults[0] !== undefined} + + + + + + + + + + + { // This hack is required so that the window still remains scrollable after removal setTimeout(() => (hmsExecutionResults = hmsExecutionResults.slice(1)), 1000) diff --git a/web/src/pages/rooms/App.svelte b/web/src/pages/rooms/App.svelte index e8e549f7..fa5180cb 100644 --- a/web/src/pages/rooms/App.svelte +++ b/web/src/pages/rooms/App.svelte @@ -90,13 +90,16 @@ for (const room of rooms) { room.devices = (res as Room[]).find(r => r.data.id === room.data.id).devices } + currentRoom = currentRoom } else { rooms = res } + const roomId = window.localStorage.getItem('current_room') const room = roomId === null ? undefined : rooms.find(r => r.data.id === roomId) currentRoom = room === undefined ? rooms[0] : room loadedData = true + refreshCounter++ } catch { $createSnackbar('Could not load rooms', [ { @@ -294,6 +297,8 @@ $requests-- } + let refreshCounter = 0 + onMount(async () => { // This call is non-blocking on purpose. loadDriverDeviceCapabilities() @@ -374,6 +379,7 @@ {#each currentRoom !== undefined ? currentRoom.devices : [] as device, i (device.id)} c.modelId === device.modelId diff --git a/web/src/pages/rooms/Device.svelte b/web/src/pages/rooms/Device.svelte index 891d3b14..8d1e6e95 100644 --- a/web/src/pages/rooms/Device.svelte +++ b/web/src/pages/rooms/Device.svelte @@ -23,6 +23,8 @@ let deviceInfoOpen = false let deviceEditOpen = false + export let refreshCounter = 0 + $: if (refreshCounter) { console.log("RELOAD"); loadExtractions() } export let style = ''