Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image Measuring Handles #249

Merged
merged 8 commits into from
Jun 10, 2021
Merged

Image Measuring Handles #249

merged 8 commits into from
Jun 10, 2021

Conversation

nicks101
Copy link
Contributor

@nicks101 nicks101 commented Apr 9, 2021

Fixes #209

  • Draggable image handles to crop the image with the selected area during image selection for pdf.
  • Using opencv package in android. Result is displayed in flutter app using method channel.
  • Only implemented for android devices.

Screenshot_1617961428

Screenshot_1617961434

anushbhatia
anushbhatia requested changes Apr 14, 2021
View reviewed changes
Copy link
Collaborator

@anushbhatia anushbhatia left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot_20210414_123828_com example doclense

It doesn't form the bounding box around tge image. Might be due to deprecated files present there.

@nicks101
Copy link
Contributor Author

It doesn't form the bounding box around tge image. Might be due to deprecated files present there.

I just ran the app on this branch, it works fine. The bounding box comes at the border ( -20 px) of the image.
Can you suggest how shall we debug this?

This is how border comes initially.

Screenshot_1618485766

@anushbhatia
Copy link
Collaborator

But why then it shows me this kind of the image

@anushbhatia
Copy link
Collaborator

But I tried with many different pictures.

@anushbhatia anushbhatia mentioned this pull request Jun 9, 2021
Open
@vercel
Copy link

vercel bot commented Jun 9, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/smaranjitghose/doc-lense/HTPjWQQTGedwTYdmwwJxpRMe7FbS
✅ Preview: https://doc-lense-git-fork-nicks101-issue-209-smaranjitghose.vercel.app

@nicks101 nicks101 changed the base branch from main to OCR June 9, 2021 16:07
@anushbhatia anushbhatia merged commit 41fb5be into smaranjitghose:OCR Jun 10, 2021
@anushbhatia anushbhatia added gssoc21 GirlScript Summer of Code 2021 Level3 GSSOC New features, major bug fixing. and removed PR: merged labels Jun 10, 2021
@nicks101 nicks101 deleted the issue-209 branch June 10, 2021 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anushbhatia anushbhatia anushbhatia requested changes

Assignees
No one assigned
Labels
gssoc21 GirlScript Summer of Code 2021 Level3 GSSOC New features, major bug fixing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implementing measuring handles
2 participants
@nicks101 @anushbhatia