-
Notifications
You must be signed in to change notification settings - Fork 268
Improve local GoReleaser build process and development docs #1408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new `goreleaser-local` target allows building CLI releases that are very similar to the ones that we release as part of our GitHub Actions release process. The target skips the hooks that trigger binaries to be pushed to GCP, allowing the release process to happen locally. Otherwise it's the same as the existing `goreleaser` target, which is intended for local snapshot builds of the CLI binary. This PR also allows the GoReleaser process to be performed with either its Pro or OSS version.
See https://goreleaser.com/deprecations#archivesformat_overridesformat for more info Also fix error in Makefile documentation for the GORELEASER_SKIP variable.
ece7611
to
b42bf14
Compare
Depending on whether the test is executed in CI/VSCode vs. running them locally with `make test`, the resulting error message was different for the `multiple-select-ui` and `ignore-provisioner-flag` test cases. For now we just test for an error, but it would be nice to refactor a bit and trigger specific error cases in the future.
24664ca
to
b14f553
Compare
The new target isn't needed, as the existing `goreleaser` target was created primarily for running it local and manually. There's no need to push artifacts when running that target.
tashian
approved these changes
Apr 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! I tested this locally with goreleaser pro 2.8.2 and make.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
goreleaser
target has been adapted to allow for building CLIreleases that are very similar to the ones that we release as part of
our GitHub Actions release process. The target skips the hooks that
trigger binaries to be pushed to GCP, allowing the release process to
happen locally.
This PR also allows the GoReleaser process to be performed with
either its Pro or OSS version using a single config file.
Other changes in this PR:
step
codebasegolangci-lint
configmake test
Example build using Pro:
Example build using OSS: