-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Group List implementation fixes #29 #30
Conversation
Co-authored-by: Oskar Stark <oskarstark@googlemail.com>
Phpdoc update (thanks to @OskarStark) better Example (thanks to @slunak)
Now im working on class ListGroupsResponseTest extends TestCase |
This PR needs a rebase please, thanks |
I think the CI works perfectly |
Can you execute |
Just make sure you do it on PHP 7.4. |
Fixed in I am using |
You should could add |
I have symfony binary installed too hence did not get the error :) |
Co-authored-by: Oskar Stark <oskarstark@googlemail.com>
Co-authored-by: Oskar Stark <oskarstark@googlemail.com>
Co-authored-by: Oskar Stark <oskarstark@googlemail.com>
Co-authored-by: Oskar Stark <oskarstark@googlemail.com>
Co-authored-by: Oskar Stark <oskarstark@googlemail.com>
Co-authored-by: Oskar Stark <oskarstark@googlemail.com>
Co-authored-by: Oskar Stark <oskarstark@googlemail.com>
Co-authored-by: Oskar Stark <oskarstark@googlemail.com>
Co-authored-by: Oskar Stark <oskarstark@googlemail.com>
Co-authored-by: Oskar Stark <oskarstark@googlemail.com>
OskarStark You want the perfect code :D |
I try to be specific as possible, also |
Co-authored-by: Oskar Stark <oskarstark@googlemail.com>
Thanks @Vitexus |
My first try.