Use find_package to search for Corrosion #7797
Conversation
api/cpp/CMakeLists.txt
Outdated
| FetchContent_MakeAvailable(Corrosion) | ||
| find_package(Corrosion QUIET) | ||
| if (NOT Corrosion_FOUND) | ||
| message("Corrosion could not be located in the CMake module search path. Downloading it from Git and building it locally") |
There was a problem hiding this comment.
I think it'd be better to leave that message out. What do you think?
|
I agree. Patch looks good, but I think the majority of our users don't get corrosion separately and would find the message confusing. One last aspect worth considering perhaps: perhaps find_package should be called with a version to ensure it's the same that we expect? |
scristall-bennu
force-pushed
the
scristall/corrosion-find-package
branch
from
b39495a to
0b9c154
Compare
|
Thanks for the notes! I removed the message and added a version to find_package. Note that I had to use 0.5 instead of 0.5.1 for the version because I think I uncovered a bug in the Corrosion release through this: the version in CorrosionConfigVersion.cmake is 0.5.0 for the v0.5.1 tag. This means, find_package(Corrosion 0.5.1) will fail to find it. FetchContent circumvents this by grabbing via the tag. |
|
Thanks! |
This PR adds a cmake module search for corrosion via find_package. This is to enable Nix which requires downloading of dependencies prior to build time.
I've also created a proof-of-concept fork of the stm32 C++ template which shows a nix derivation for Slint:
https://github.com/scristall-bennu/slint-cpp-templates-stm32-nix