Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slintpad: Update monaco editor and resize the editor to stop bogus scrollbar from appearing #4818

Merged
merged 2 commits into from
Mar 12, 2024

Conversation

hunger
Copy link
Member

@hunger hunger commented Mar 11, 2024

This patch took way to long to make :-/

Each time you look into the Monaco editor and surrounding tools we need, something subtle has changed yet again. This time it seems to be OK not to initialize extensions anymore and of course we no longer need to "treemend" ourselves anymore, we need to pull in a pre-tree-mended replacement/override instead.

@ogoffart
Copy link
Member

Great.
But does this fix a problem? If not, I'd suggest we wait until after the release.

@hunger
Copy link
Member Author

hunger commented Mar 12, 2024

It does fix #4805

@hunger hunger merged commit 3cf663e into slint-ui:master Mar 12, 2024
36 checks passed
@hunger hunger deleted the heads/refs/slintpad_sb branch March 12, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants