Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fmt: format two way bindings #4804

Merged
merged 1 commit into from
Mar 11, 2024
Merged

fmt: format two way bindings #4804

merged 1 commit into from
Mar 11, 2024

Conversation

ogoffart
Copy link
Member

@ogoffart ogoffart commented Mar 9, 2024 •
edited
Loading

also test that running slint-lsp format another time don't cause changes

Closes #4797

github-actions[bot]
github-actions bot reviewed Mar 9, 2024
View reviewed changes
tronical
tronical approved these changes Mar 9, 2024
View reviewed changes
Copy link
Member

@tronical tronical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hah, I had a local WIP that did the same except for the format_property_declaration bit - I couldn’t figure it out:).

@ogoffart
Copy link
Member Author

(i removed the test commit as that doesn't pass yet)

@tronical
Copy link
Member

(i removed the test commit as that doesn't pass yet)

Good idea :). The two-way binding change itself is a great improvement already.

@ogoffart ogoffart mentioned this pull request Mar 11, 2024
Closed
@ogoffart ogoffart merged commit c3a2ad1 into master Mar 11, 2024
36 checks passed
@ogoffart ogoffart deleted the olivier/lsp branch March 11, 2024 09:40
@ogoffart ogoffart restored the olivier/lsp branch September 26, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@tronical tronical tronical approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Slint format will add an empty line right after two way binding
2 participants
@ogoffart @tronical