-
Notifications
You must be signed in to change notification settings - Fork 644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: color: add channel properties to color
plus linear-mix
#4796
Conversation
This is a much cleaned up version of the previous PR with extraneous work pulled out to a separate branch. I think everything is covered, but lets see what the pipeline tests say. |
I'm not sure what this is about:
Does this mean that the methods and struct fields are in conflict? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the PR. Some comment inside
Sorry to insist, but i still don't understand what you mean. (I cannot try your example since it needs a custom Slint) (I've replicated a way to compare different way to mix color currently afailable, but they seem similar: link) |
@ogoffart I must be losing my mind... I could have sworn one was smoother when stepping from one colour to the next. The A screenshot doesn't work here as it is the visible movement from one colour to the next in a two colour mix(n, n+1) selected from an array.. I am now non-plussed on whether this part stays in or not. If you prefer to remove it I'm okay with that. Though I do recall the |
Yes, please remove the interpolate function, as it is a duplicate of |
Add extra properties to the `color` type. - `red` - `green` - `blue` - `alpha`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot. Looks good.
Add extra properties to the
color
type.red
green
blue
alpha
Add extra method to the
color
typelinear-mix
This provides a simple linear mixing of two ARGB colors with a scaling factor