Energy-monitor: android build and wasm simplicifation #4769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogoffart
commented
Mar 6, 2024
| name = "energy-monitor" | ||
|
|
||
| [lib] | ||
| crate-type = ["cdylib", "lib"] |
There was a problem hiding this comment.
I didn't add a name but the default name for the library ("energy_monitor") is not the same as the binary name ("energy-monitor") and therefore it shouldn't conflict.
| #![cfg_attr(all(feature = "mcu-board-support", not(feature = "simulator")), no_main)] | ||
|
|
||
| #[cfg(feature = "mcu-board-support")] |
There was a problem hiding this comment.
almost all the code of this file was moved without change to lib.rs
This demo support both mcus, web, desktop and mobile. Split in a lib.rs so that there are no warnings even if it means some dummy wrapper in main. Add instructions in the README
FloVanGH
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This demo support both mcus, web, desktop and mobile.
Split in a lib.rs so that there are no warnings even if it means some dummy wrapper in main.
Add instructions in the README