Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor JavaScript example to use template project #4758

Merged
merged 3 commits into from
Mar 8, 2024

Conversation

ChrisChinchilla
Copy link
Collaborator

No description provided.

@ChrisChinchilla ChrisChinchilla marked this pull request as ready for review March 5, 2024 16:29
Copy link
Member

@tronical tronical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks overall good. A few comments inside.

Co-authored-by: Simon Hausmann <simon.hausmann@slint.dev>
@ChrisChinchilla ChrisChinchilla requested a review from tronical March 8, 2024 09:37
@ChrisChinchilla ChrisChinchilla merged commit 203259f into master Mar 8, 2024
36 checks passed
@ogoffart ogoffart deleted the chrischinch/node-template-qs branch August 28, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants