Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor CPP Quickstart to use project template project #4722

Merged
merged 12 commits into from
Mar 11, 2024
Merged

Refactor CPP Quickstart to use project template project #4722

merged 12 commits into from
Mar 11, 2024

Conversation

ChrisChinchilla
Copy link
Collaborator

No description provided.

@ChrisChinchilla @github-actions
Update docs/tutorial/cpp/src/main_initial.cpp
ccc9ab5 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@tronical
Copy link
Member

Looks good at first glance. I'll take a closer look tomorrow. The CI is failing because we try to compile the CMakeLists.txt in the source folder to ensure that all the .cpp code used also compiles (we've been bitten by that a few times).

tronical
tronical reviewed Mar 1, 2024
View reviewed changes
ChrisChinchilla and others added 9 commits March 1, 2024 10:47
@ChrisChinchilla @tronical
Update docs/tutorial/cpp/src/game_logic_in_cpp.md
edd1604 
Co-authored-by: Simon Hausmann <simon.hausmann@slint.dev>
@ChrisChinchilla @tronical
Update docs/tutorial/cpp/src/creating_the_tiles_from_cpp.md
1bf8698 
Co-authored-by: Simon Hausmann <simon.hausmann@slint.dev>
@ChrisChinchilla @tronical
Update docs/tutorial/cpp/src/from_one_to_multiple_tiles.md
8641b2e 
Co-authored-by: Simon Hausmann <simon.hausmann@slint.dev>
@ChrisChinchilla @tronical
Update docs/tutorial/cpp/src/from_one_to_multiple_tiles.md
61dabde 
Co-authored-by: Simon Hausmann <simon.hausmann@slint.dev>
@ChrisChinchilla @tronical
Update docs/tutorial/cpp/src/getting_started.md
235c108 
Co-authored-by: Simon Hausmann <simon.hausmann@slint.dev>
@ChrisChinchilla
Remove commented text
232505f
@ChrisChinchilla
Merge branch 'chrischinch/cpp-template-qs' of github.com:slint-ui/sli…
085c5f1 
…nt into chrischinch/cpp-template-qs

# Conflicts:
#	docs/tutorial/cpp/src/getting_started.md
@ChrisChinchilla
Re-add removed powershell icon commands
645e338
@ChrisChinchilla
Undo rename
b4ffaa3
@ChrisChinchilla
Copy link
Collaborator Author

@tronical I think that undid the rename…

@ChrisChinchilla
Copy link
Collaborator Author

@tronical I wanted ot get this wrapped up and it looks like I got it working :)

@tronical
Copy link
Member

Wohoo :)

@ChrisChinchilla ChrisChinchilla merged commit 9345638 into master Mar 11, 2024
36 checks passed
@ChrisChinchilla ChrisChinchilla deleted the chrischinch/cpp-template-qs branch March 11, 2024 14:09
@ChrisChinchilla ChrisChinchilla mentioned this pull request Mar 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@tronical tronical tronical approved these changes

@hunger hunger Awaiting requested review from hunger

@ogoffart ogoffart Awaiting requested review from ogoffart

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChrisChinchilla @tronical