live preview: Fix moving of elements #4645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogoffart
approved these changes
Feb 20, 2024
| @@ -71,6 +71,20 @@ pub fn find_element_indent(element: &ElementRc) -> Option<String> { | |||
| None | |||
| } | |||
|
|
|||
| /// Try to find the parent of element `child` below `root`. | |||
| pub fn search_for_parent_element(root: &ElementRc, child: &ElementRc) -> Option<ElementRc> { | |||
There was a problem hiding this comment.
please avoid adding stuff to that module and keep helper function private near where they are used.
We can always move the function later if they are used by several modules
There was a problem hiding this comment.
So now the function is there twice, and this one is unused
The positioning needs to happen relative to the position of the parent element, not using global coordinates.
|
You are right! Sorry for that! #4667 fixes this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The positioning needs to happen relative to the position of the parent element, not using global coordinates.