live preview: Update selection when size of UI changes #4644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changing the size of a UI will most likely move elements around. So reselect the current selection when that happens. This is not a proper solution: It e.g. ignores animations changing element sizes, etc. but it does handle one annoying case.
ogoffart
approved these changes
Feb 20, 2024
| @@ -93,6 +93,21 @@ pub fn set_contents(url: &VersionedUrl, content: String) { | |||
| } | |||
| } | |||
|
|
|||
| pub fn reselect_element() { | |||
There was a problem hiding this comment.
doesn't this belong in the selection module?
There was a problem hiding this comment.
Yes, it belongs into element selection, but it also needs PREVIEW_STATE and I am trying to keep that in preview.rs. So I moved the re-selection code there.
There was a problem hiding this comment.
you can always use super::PREVIEW_STATE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing the size of a UI will most likely move elements around. So reselect the current selection when that happens.
This is not a proper solution: It e.g. ignores animations changing element sizes, etc. but it does handle one annoying case.