C++ package: use Qt on Linux, not on Windows/Mac #4641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 4b4a7d6 attempted to remove the Qt from the C++ package on Windows, but infortunately, it removed the setup of Qt on Linux instead of Windows. As a result, 1.4.x binary packages on Linux are not build with Qt, and on Windows are build with Qt but no longer ship Qt so are broken In the master branch we no longer use Qt by default already on Windows even if it is installed. But this patch restore the fact that the binary package are built with Qt on Linux
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 4b4a7d6 attempted to remove the Qt from the C++ package on Windows, but infortunately, it removed the setup of Qt on Linux instead of Windows.
As a result, 1.4.x binary packages on Linux are not build with Qt, and on Windows are build with Qt but no longer ship Qt so are broken
In the master branch we no longer use Qt by default already on Windows even if it is installed.
But this patch restore the fact that the binary package are built with Qt on Linux