live preview: Actually store the document version #4605
Conversation
... so that we can detect outdated edits later.
| let old = cache.source_code.insert(url.url().clone(), (url.version().clone(), content.clone())); | ||
| if cache.dependency.contains(url.url()) { | ||
| if let Some((old_version, old)) = old { | ||
| if content == old && old_version == *url.version() { |
There was a problem hiding this comment.
I think we wouldn't need to reload the preview if the version change but the document didn't. Do i'd skip the test on the version there.
There was a problem hiding this comment.
But then we stick with the old version :-/
It should not happen in practice anyway that the version changed and the content did not, so this is more of a safety net.
|
This is to prevent the editor to mess up the text buffers.
It's the document version number used by the LS protocol, which we send along in all WorkspaceEdit requests. If the editor has a newer version of the document than the one the live preview/LSP request a change on, that change will be rejected by the editor.
The editor will reject to apply edits and will push out the new document version -- which triggres the LSP/previewer to update. So it's not handled per se: Our inputs change and we update. |
... so that we can detect outdated edits later.