lsp: Return the node index as well as the Element ref when filtering #4604
Conversation
There was a problem hiding this comment.
Probably would be nice to document a bit more the function. We are in the common module, so it might not be obvious what this do. (also i didn't find the name very obvious, it says it is a filter, but it only take one element.)
I even wonder why this is in common this doesn't seem to be a funciton that would be re-used a lot.
Maybe have a is_ignored_element(&syntax_nodes::Element)->bool would be a function that i can see being re-used.
|
It takes one element and filters the nodes attached to it. I could turn it into a is_*(...) returning a boolean, true, doing the iteration elsewhere. |
... returning a bool. Do the iteration where needed instead.
|
Turned this into a function taking an |
| .next() | ||
| .and_then(|n| { |
There was a problem hiding this comment.
The use of ? would simplify this function slightly
Return the node index as well as the &Element itself when filtering nodes on Elements. This allows for easier access/storage of the which node is actually relevant.