Minimal 9slice border-image support #4594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
ogoffart
force-pushed
the
olivier/image
branch
from
856786b to
300e7e0
Compare
tronical
approved these changes
Feb 10, 2024
| (*painter)->drawPixmap(dest_rect, pixmap, source_rect); | ||
| (*painter)->restore(); | ||
| }}; | ||
| for fit in fit { |
There was a problem hiding this comment.
This makes me think that the vector should be called “fits” or “fitted_images”.
| @@ -13,6 +13,8 @@ TestCase := Rectangle { | |||
| source-clip-x: 20; | |||
| } | |||
|
|
|||
| out property <image> with-border: @image-url("dog.jpg", 9slice(12 13 14 15)); | |||
There was a problem hiding this comment.
This tests basically the code generators, right?
There was a problem hiding this comment.
Yes. We do not have test for renderers other than the software renderer, and that's only tested with rust.
ogoffart
force-pushed
the
olivier/image
branch
from
17780f5 to
a39163f
Compare
This is important when zooming, and still allow images of 65535 pixel width or height
The test will test that things are rendered the same with a clip. But that gives bad error when rendering images with high ferquencies because a small difference in the initial condition of drawing may result in being off by a pixel.
ogoffart
force-pushed
the
olivier/image
branch
from
a39163f to
69d6798
Compare
|
@tronical I'll merge this soon if you don't see an objection. |
tronical
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
9slice(...)attribute to the @image-urlCC #1529