Add API for minimize/maximize on Window component #4581
Conversation
|
|
|
I've tried my best to test this as much as I can on my system which is Windows 10 64-bit x86_64. I don't have convenient access to MacOS or Linux currently so it might be beneficial to get more testing on those systems if there are concerns with the code. I made sure to test a combination of fixed size / preferred size for the window and the behavior is as expected. I've recorded some quick demos of both the winit and Qt backends showing the following behaviors:
Winit: winit-min-max.mp4Qt: qt-min-max.mp4Closes issue: #4400 |
There was a problem hiding this comment.
Thanks a lot for the patch. Looks very good. I really like the fact that you added comments with links to relevant issues.
This still need fixup to the JS and C++ bindings, but we can do that after.
However, i wonder if is_minimized, is_fullscreen and so on is not better api for the getter in rust on the Window. this mirrors the API in winit, and it cannot be confused with something that would, eg, return a minimized window.
| #[napi(setter)] | ||
| pub fn set_minimized(&self, minimized: bool) { | ||
| self.inner.window().set_minimized(minimized) | ||
| } |
There was a problem hiding this comment.
change in this files need to be reflected ion index.ts, i think
|
I'd like to go forward with this PR. (We can fix the C++ and JS bindings after this PR.) |
|
@ogoffart No problem, sorry for the delay but I was away this weekend. I've made the changes as requested, namely:
Regarding the C changes. I only implemented as much as was previously implemented for fullscreen. Wasn't sure to what extent the full C++ API needed to be changed. |
| @@ -279,9 +279,19 @@ impl<'a> WindowProperties<'a> { | |||
| } | |||
|
|
|||
| /// Returns true if the window should be shown fullscreen; false otherwise. | |||
| pub fn fullscreen(&self) -> bool { | |||
| pub fn is_fullscreen(&self) -> bool { | |||
There was a problem hiding this comment.
Unfortunately, we can't rename this function since it is already public in previous version.
We'll have to re-add it as a deprecated function.
Or the alternative is to keep the old name and leave the is_ prefix out of WindowProperties. But i think it's better to be consistent and keep the is_ prefix for all the window states
There was a problem hiding this comment.
Makes sense, I added back fullscreen() to WindowProperties as a deprecated method
Update the
Windowapi to support programmatically minimizing and maximizing windows on theQtandwinitbackends. The following methods are new:Window::set_minimizedWindow::minimizedWindow::set_maximizedWindow::maximizedWindow::fullscreen