Medication variables are now sorted by position, addresses #697.

app/controllers/editor/medication_variables_controller.rb

@@ -60,6 +60,6 @@ def find_medication_variable_or_redirect
   end
 
   def medication_variable_params
-    params.require(:medication_variable).permit(:name, :autocomplete_values)
+    params.require(:medication_variable).permit(:name, :autocomplete_values, :position)
   end
 end

app/models/concerns/medications.rb

@@ -5,7 +5,7 @@ module Medications
 
   included do
     # Relationships
-    has_many :medication_variables, -> { current }
+    has_many :medication_variables, -> { current.order("position nulls last") }
     has_many :medications
     has_many :medication_values
   end

app/views/editor/medication_variables/_form.html.haml

@@ -3,4 +3,5 @@
 = form_with model: [medication_variable.project, medication_variable], url: url, method: method, local: true do |form|
   = render "forms/horizontal/text_field", form: form, object: medication_variable, key: :name, autocomplete: "off"
   = render "forms/horizontal/text_area", form: form, object: medication_variable, key: :autocomplete_values, rows: 7, help_text: "Place values on separate lines"
+  = render "forms/horizontal/number_field", form: form, object: medication_variable, key: :position
   = render "forms/horizontal/submit", form: form, object: [medication_variable.project, medication_variable], cancel: url

db/migrate/20190311154921_add_position_to_medication_variables.rb

@@ -0,0 +1,5 @@
+class AddPositionToMedicationVariables < ActiveRecord::Migration[6.0]
+  def change
+    add_column :medication_variables, :position, :integer
+  end
+end