slack-vitess-r15.0.5: use go1.21
#260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Co-authored-by: frouioui <frouioui@users.noreply.github.com> Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
timvaillancourt
added
upstream-backport
|
running tests for vitess.io/vitess/go/test/endtoend/vtctldweb
go: downloading github.com/tebeka/selenium v0.9.9
go: downloading github.com/blang/semver v3.5.1+incompatible
unknown error - 33: session not created: This version of ChromeDriver only supports Chrome version 90
Current browser version is 116.0.5845.96 with binary path /usr/bin/chromium
(Driver info: chromedriver=90.0.4430.24 (4c6d850f087da467d926e8eddb76550aed655991-refs/branch-heads/4430@{#429}),platform=Linux 5.15.0-1058-azure x86_64)
FAIL vitess.io/vitess/go/test/endtoend/vtctldweb 1.213s
FAIL
2024/03/19 01:01:08 mysql57.web_test: saving test output to _test/20240319-004814.3795/mysql57.web_test-1.1.log
2024/03/19 01:01:08 mysql57.web_test: FAILED (try 1/1) in 1m33.5s: exit status 1
2024/03/19 01:01:08 mysql57.web_test: retry limit exceeded
2024/03/19 01:01:08 Removing temp dir /tmp/vt_85636810
2024/03/19 01:01:08 ============================================================
2024/03/19 01:01:08 mysql57.java PASS
2024/03/19 01:01:08 mysql57.pitr PASS
2024/03/19 01:01:08 mysql57.web_test FAIL (1 tries)
2024/03/19 01:01:08 ============================================================
2024/03/19 01:01:08 2 PASSED, 0 FLAKY, 1 FAILED, 0 SKIPPED
2024/03/19 01:01:08 Total time: 12m54.2s
exit status 1
Error: Process completed with exit code 1. |
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
tanjinx
approved these changes
Mar 26, 2024
timvaillancourt
added a commit
that referenced
this pull request
May 3, 2024
This reverts commit 1533744.
timvaillancourt
added a commit
that referenced
this pull request
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the v15 release to go1.21
This is the GA release of the builtin Go
slogpackage. I plan to use this library instead of the Zap-logger library we used on v14 and I'll upstream the changesThis includes v18 PR vitessio#13853 to allow go1.21
Related Issue(s)
Checklist
Deployment Notes