Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slack-vitess-r15.0.5: skip CI only if commit is not a PR #257

Closed

Conversation

timvaillancourt
Copy link
Member

@timvaillancourt timvaillancourt commented Mar 15, 2024

Description

This PR causes all PRs to run CI checks, even if they don't match the complicated/unclear regex matches upstream uses to sometimes skip these checks

I don't have full context on why upstream matches only certain branch names, but we shouldn't need to do this - running CI checks on any PR should be fine for us

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
@timvaillancourt timvaillancourt requested a review from a team as a code owner March 15, 2024 19:18
@github-actions github-actions bot added this to the v15.0.5 milestone Mar 15, 2024
@timvaillancourt
Copy link
Member Author

Closing, won't merge. I misunderstood this logic and this is no longer needed

@timvaillancourt timvaillancourt deleted the ci-any-pr-slack-vitess-r15.0.5 branch March 26, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants