move sort to test

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
slackhq · Feb 10, 2025 · 81a2817 · 81a2817
1 parent 1985769
commit 81a2817
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/go/vt/vtorc/logic/tablet_discovery.go b/go/vt/vtorc/logic/tablet_discovery.go
@@ -175,9 +175,6 @@ func getAllTablets(ctx context.Context, cells []string) (tabletsByCell map[strin
 		})
 	}
 	_ = eg.Wait() // always nil
-	if len(failedCells) > 1 {
-		slices.Sort(failedCells)
-	}
 	return tabletsByCell, failedCells
 }
 

diff --git a/go/vt/vtorc/logic/tablet_discovery_test.go b/go/vt/vtorc/logic/tablet_discovery_test.go
@@ -868,6 +868,7 @@ func TestGetAllTablets(t *testing.T) {
 	// confirm zone1 + zone2 succeeded and zone3 + zone4 failed
 	tabletsByCell, failedCells := getAllTablets(ctx, []string{"zone1", "zone2", "zone3", "zone4"})
 	require.Len(t, tabletsByCell, 2)
+	slices.Sort(failedCells)
 	require.Equal(t, []string{"zone3", "zone4"}, failedCells)
 	for _, tablets := range tabletsByCell {
 		require.Len(t, tablets, 1)