Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent sort order #5

Open
mockdeep opened this issue Apr 20, 2016 · 7 comments
Open

Inconsistent sort order #5

mockdeep opened this issue Apr 20, 2016 · 7 comments

Comments

@mockdeep
Copy link

It appears to be OS dependent, but packages keep shifting back and forth within npm-shrinkwrap.json, e.g.:

       "dependencies": {
-        "jsonparse": {
-          "version": "0.0.5"
-        },
         "JSONStream": {
           "version": "0.10.0"
+        },
+        "jsonparse": {
+          "version": "0.0.5"
         }
       }

I suspect it has something to do with MacOS not being case sensitive. We also have people using Linux.

@glenjamin
Copy link
Contributor

Is this with npm2? I think npm3 sorts entries.

@mockdeep
Copy link
Author

No, I'm on npm version 3.8.1:

$ npm --version
3.8.1

@glenjamin
Copy link
Contributor

I think sort order was what led to the creation of https://github.com/evocateur/shrinkwarp - adding sort order into shronkwrap would be quite tricky without changing quite a lot I think.

@mockdeep
Copy link
Author

Hmm, looks like that was made for npm 2, though. Do you not want sorting to be part of shonkwrap?

@glenjamin
Copy link
Contributor

I'm not against it, I just like how small it is at the moment. Sorting would require quite a bit more code I think.

@mockdeep
Copy link
Author

It is pretty concise. I might want to poke around with it a bit, and potentially tack on some additional functionality (e.g. dedupe). Would it be better for me to fork it?

Side note: I don't see a license file. Not sure what the procedure is on forking when one isn't present.

@glenjamin
Copy link
Contributor

The license is BSD-3, as noted in the package.json.

If you manage to come up with an easy way to get things sorted, a PR would be ace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants