Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot use from wsl without a --host param (and probably directory too) #5

Open
XertroV opened this issue Oct 22, 2024 · 4 comments · May be fixed by #6
Open

Cannot use from wsl without a --host param (and probably directory too) #5

XertroV opened this issue Oct 22, 2024 · 4 comments · May be fixed by #6

Comments

@XertroV
Copy link

XertroV commented Oct 22, 2024

I have a modified version of tm-remote-build on my main machine and while setting things up again on my laptop re-found that I can't use it from WSL. The two args I added to make it work was host and directory.

The command I use is tm-remote-build load folder "$PLUGIN_FOLDER_NAME" --host 172.18.16.1 --port 30000 -v -d "$HOME/OpenplanetNext/"

I can share my modifications in a few weeks when I'm back in Australia.

@skybaks
Copy link
Owner

skybaks commented Oct 23, 2024

Those additions make sense for wsl. I may be able to put something together for that sooner than a few weeks

@skybaks skybaks linked a pull request Oct 23, 2024 that will close this issue
@skybaks
Copy link
Owner

skybaks commented Oct 23, 2024

As i suspected, adding the --host argument was very easy.

We dont need the Openplanet directory to make the plugin load so is that -d argument that you added just to help it find the Openplanet.log file? By default its using a filepath returned from Openplanet itself which would probably not end up being a valid path on WSL.
I can install WSL myself just to confirm. But anyway I think I'll add the -d argument to help with finding the log file and hopefully that will be what you need.

@XertroV
Copy link
Author

XertroV commented Oct 24, 2024

so is that -d argument that you added just to help it find the Openplanet.log file?
Yeah I think so.

And yeah, the changes I made were pretty minimal. Basically just a bit of refactoring to override defaults.

I'm happy to test if there's a branch or whatever.

@skybaks
Copy link
Owner

skybaks commented Oct 25, 2024

I think i should have it all working now but would love your feedback if you dont mind. Branch name is feature/configurable-host or you can look at #6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants