Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shaders, Resourcepacks, and Updates #134

Merged
merged 21 commits into from
Mar 7, 2025
Merged

Conversation

AquaCobalt
Copy link
Contributor

@AquaCobalt AquaCobalt commented Jan 20, 2025

Jan 20:

Created shaders.mdx.

It's pretty detailed and has all the info needed but it may be a little long. If there's anything I should change please request them <3

Next Project: Texture packs, resource packs, more ways to install shaders, and further improvements.

EDIT: I ended up adding the resourcepacks.mdx file to this PR.

Feb 27:

EDIT: This originally started out as a PR for my shaders guide, but it now also includes a resource packs guide and some updating of some outdated docs.

Cheers 🎉

@indexerrowaty indexerrowaty self-assigned this Jan 20, 2025
@indexerrowaty indexerrowaty added the documentation Improvements or additions to documentation label Jan 20, 2025
@AquaCobalt AquaCobalt changed the title Shaders Guide Shaders & Resource Packs Guide Feb 15, 2025
@SoyRA
Copy link
Contributor

SoyRA commented Feb 26, 2025

On macOS, it may be downloaded as a folder, in that case, compress it into a .ZIP file.

  1. Put the extensions in lowercase like in the whole repo :'v
  2. Either in .zip or unzipped, it will work! So maybe macOS doesn't need to compress it.

Find your resourcepacks folder located in your Minecraft folder.

Give link to where the game is installed: /faq/launcher-related#where-is-sklauncher-installed

And the same about the shaders guide.
This was a quick review! Maybe there are more things or everything is ok. a,a

@AquaCobalt AquaCobalt changed the title Shaders & Resource Packs Guide Shaders, Resourcepacks, and Updates Feb 26, 2025
@SoyRA
Copy link
Contributor

SoyRA commented Mar 7, 2025

Well, I don't think I've any more things to correct.
Tomorrow or the day after I approve the PR if nobody has suggestions or anything.

PS: I know there are minor inconsistencies, I'll fix it myself in a future PR.

@AquaCobalt
Copy link
Contributor Author

literally just take over my PR at this point. this is now your problem + my work here is done✌️

(after installing maps guide at least)

Copy link
Member

@indexerrowaty indexerrowaty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Let me know if this is ready for merging.

@AquaCobalt
Copy link
Contributor Author

Looks good to me! Let me know if this is ready for merging.

I believe it should be 100% ready for merging now since I've done everything I'd planned on doing.

P.S. I only have one last project to do and that is a guide for installing maps/worlds, but I'll do that in the future.

Thank you 🎉

@indexerrowaty indexerrowaty merged commit 7627a03 into sklauncher:main Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants