revert!: magnifier

CHANGELOG.md

@@ -13,6 +13,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Changed
 
 - **BREAKING**: Change the `options` parameter class type from `QuillToolbarToggleStyleButtonOptions` to `QuillToolbarClipboardButtonOptions` in `QuillToolbarClipboardButton`. To migrate, use `QuillToolbarClipboardButtonOptions` instead of `QuillToolbarToggleStyleButtonOptions` [#2433](https://github.com/singerdmx/flutter-quill/pull/2433).
+- **BREAKING**: Change the `onTapDown` to accept `TapDownDetails` instead of `TapDragDownDetails` (revert [#2128](https://github.com/singerdmx/flutter-quill/pull/2128/files#diff-49ca9b0fdd0d380a06b34d5aed7674bbfb27fede500831b3e1279615a9edd06dL259-L261) due to regressions).
+- **BREAKING**: Change the `onTapUp` to accept `TapUpDetails` instead of `TapDragUpDetails` (revert [#2128](https://github.com/singerdmx/flutter-quill/pull/2128/files#diff-49ca9b0fdd0d380a06b34d5aed7674bbfb27fede500831b3e1279615a9edd06dL263-L265) due to regressions).
+
+### Removed
+
+- **BREAKING**: The magnifier feature due to buggy behavior [#2413](https://github.com/singerdmx/flutter-quill/pull/2413). See [#2406](https://github.com/singerdmx/flutter-quill/issues/2406) for a list of reasons.
 
 ## [11.0.0-dev.19] - 2025-01-10
 

doc/migration/10_to_11.md

@@ -352,6 +352,8 @@ required for **custom toolbars**.
 - Moved `onClipboardPaste` from `QuillControllerConfig` to `QuillClipboardConfig`. Added `clipboardConfig` property to `QuillControllerConfig`.
 - Moved `onImagePaste` and `onGifPaste` from the editor's config (`QuillEditorConfig` or `QuillRawEditorConfig`) to the clipboard's config (`QuillClipboardConfig`), which is part of the controller's config (`QuillControllerConfig`).
 - Changed the options type from `QuillToolbarToggleStyleButtonOptions` to `QuillToolbarClipboardButtonOptions` in `QuillToolbarClipboardButton`, use the new options class.
+- Change the `onTapDown` to accept `TapDownDetails` instead of `TapDragDownDetails` (revert [#2128](https://github.com/singerdmx/flutter-quill/pull/2128/files#diff-49ca9b0fdd0d380a06b34d5aed7674bbfb27fede500831b3e1279615a9edd06dL259-L261) due to regressions).
+- Change the `onTapUp` to accept `TapUpDetails` instead of `TapDragUpDetails` (revert [#2128](https://github.com/singerdmx/flutter-quill/pull/2128/files#diff-49ca9b0fdd0d380a06b34d5aed7674bbfb27fede500831b3e1279615a9edd06dL263-L265) due to regressions).
 
 ## 💥 Breaking behavior
 
@@ -483,6 +485,23 @@ QuillSimpleToolbar(
 )
 ```
 
+### 5. Removal of the magnifier feature
+
+Unfortunately, **due to the high volume of issues and bugs introduced by the magnifier**, this feature has been removed to ensure stability.
+
+This feature was introduced in [9.6.0](https://pub.dev/packages/flutter_quill/versions/9.6.0/changelog#960) which supports Android and iOS only.
+
+For more details, refer to [#2406](https://github.com/singerdmx/flutter-quill/issues/2406).
+
+```diff
+QuillEditorConfig(
+-   magnifierConfiguration: TextMagnifierConfiguration()
+)
+// No longer supported, subscribe to https://github.com/singerdmx/flutter-quill/issues/1504 for updates
+```
+
+In the future, new features will be implemented with more caution to avoid possible issues.
+
 ## 🚧 Experimental
 
 APIs that were indicated as stable but are now updated to indicate
@@ -494,7 +513,6 @@ in non-major releases:
 - The `QuillEditorConfig.characterShortcutEvents` and `QuillEditorConfig.spaceShortcutEvents`.
 - The `QuillControllerConfig.onClipboardPaste`.
 - The `QuillEditorConfig.customLeadingBlockBuilder`.
-- The magnifier feature including `QuillEditorConfig.magnifierConfiguration`.
 - The `shouldNotifyListeners` in `QuillController.replaceText()`, `QuillController.replaceText()`, `QuillController.formatSelection()`.
 - The `QuillController.clipboardSelection()`.
 - The `CopyCutServiceProvider`, `CopyCutService`, and `DefaultCopyCutService`.

lib/src/editor/config/editor_config.dart

@@ -1,7 +1,6 @@
 import 'dart:ui' as ui;
 
 import 'package:flutter/cupertino.dart';
-import 'package:flutter/gestures.dart';
 import 'package:flutter/material.dart';
 import 'package:meta/meta.dart' show experimental;
 
@@ -73,7 +72,6 @@ class QuillEditorConfig {
     this.contextMenuBuilder,
     this.editorKey,
     this.requestKeyboardFocusOnCheckListChanged = false,
-    @experimental this.magnifierConfiguration,
     this.textInputAction = TextInputAction.newline,
     this.enableScribble = false,
     this.onScribbleActivated,
@@ -338,12 +336,11 @@ class QuillEditorConfig {
 
   // Returns whether gesture is handled
   final bool Function(
-          TapDragDownDetails details, TextPosition Function(Offset offset))?
-      onTapDown;
+      TapDownDetails details, TextPosition Function(Offset offset))? onTapDown;
 
   // Returns whether gesture is handled
   final bool Function(
-      TapDragUpDetails details, TextPosition Function(Offset offset))? onTapUp;
+      TapUpDetails details, TextPosition Function(Offset offset))? onTapUp;
 
   // Returns whether gesture is handled
   final bool Function(
@@ -436,11 +433,6 @@ class QuillEditorConfig {
   /// should we request keyboard focus??
   final bool requestKeyboardFocusOnCheckListChanged;
 
-  /// This feature is currently experimental and only supported
-  /// on **Android** and **iOS**.
-  @experimental
-  final TextMagnifierConfiguration? magnifierConfiguration;
-
   /// Default to [TextInputAction.newline]
   final TextInputAction textInputAction;
 
@@ -488,11 +480,9 @@ class QuillEditorConfig {
     Brightness? keyboardAppearance,
     ScrollPhysics? scrollPhysics,
     ValueChanged<String>? onLaunchUrl,
-    bool Function(
-            TapDragDownDetails details, TextPosition Function(Offset offset))?
+    bool Function(TapDownDetails details, TextPosition Function(Offset offset))?
         onTapDown,
-    bool Function(
-            TapDragUpDetails details, TextPosition Function(Offset offset))?
+    bool Function(TapUpDetails details, TextPosition Function(Offset offset))?
         onTapUp,
     Iterable<EmbedBuilder>? embedBuilders,
     EmbedBuilder? unknownEmbedBuilder,
@@ -512,7 +502,6 @@ class QuillEditorConfig {
     GlobalKey<EditorState>? editorKey,
     TextSelectionThemeData? textSelectionThemeData,
     bool? requestKeyboardFocusOnCheckListChanged,
-    TextMagnifierConfiguration? magnifierConfiguration,
     TextInputAction? textInputAction,
     bool? enableScribble,
     void Function()? onScribbleActivated,
@@ -581,8 +570,6 @@ class QuillEditorConfig {
       requestKeyboardFocusOnCheckListChanged:
           requestKeyboardFocusOnCheckListChanged ??
               this.requestKeyboardFocusOnCheckListChanged,
-      magnifierConfiguration:
-          magnifierConfiguration ?? this.magnifierConfiguration,
       textInputAction: textInputAction ?? this.textInputAction,
       enableScribble: enableScribble ?? this.enableScribble,
       onScribbleActivated: onScribbleActivated ?? this.onScribbleActivated,

lib/src/editor/editor.dart

@@ -2,7 +2,7 @@ import 'dart:math' as math;
 
 import 'package:flutter/cupertino.dart'
     show CupertinoTheme, cupertinoTextSelectionControls;
-import 'package:flutter/foundation.dart' show ValueListenable, kIsWeb;
+import 'package:flutter/foundation.dart';
 import 'package:flutter/gestures.dart';
 import 'package:flutter/material.dart';
 import 'package:flutter/rendering.dart';
@@ -16,7 +16,6 @@ import '../document/nodes/container.dart' as container_node;
 import '../document/nodes/leaf.dart';
 import 'config/editor_config.dart';
 import 'embed/embed_editor_builder.dart';
-import 'magnifier/magnifier_platform_support.dart';
 import 'raw_editor/config/raw_editor_config.dart';
 import 'raw_editor/raw_editor.dart';
 import 'widgets/box.dart';
@@ -320,7 +319,6 @@ class QuillEditorState extends State<QuillEditor>
         onScribbleActivated: configurations.onScribbleActivated,
         scribbleAreaInsets: configurations.scribbleAreaInsets,
         readOnlyMouseCursor: configurations.readOnlyMouseCursor,
-        magnifierConfiguration: configurations.magnifierConfiguration,
         textInputAction: configurations.textInputAction,
         onPerformAction: configurations.onPerformAction,
       ),
@@ -448,10 +446,9 @@ class _QuillEditorSelectionGestureDetectorBuilder
         SelectionChangedCause.longPress,
       );
     }
-    editor?.updateMagnifier(details.globalPosition);
   }
 
-  bool _isPositionSelected(TapDragUpDetails details) {
+  bool _isPositionSelected(TapUpDetails details) {
     if (_state.controller.document.isEmpty()) {
       return false;
     }
@@ -474,7 +471,7 @@ class _QuillEditorSelectionGestureDetectorBuilder
   }
 
   @override
-  void onTapDown(TapDragDownDetails details) {
+  void onTapDown(TapDownDetails details) {
     if (_state.configurations.onTapDown != null) {
       if (renderEditor != null &&
           _state.configurations.onTapDown!(
@@ -495,7 +492,7 @@ class _QuillEditorSelectionGestureDetectorBuilder
   }
 
   @override
-  void onSingleTapUp(TapDragUpDetails details) {
+  void onSingleTapUp(TapUpDetails details) {
     if (_state.configurations.onTapUp != null &&
         renderEditor != null &&
         _state.configurations.onTapUp!(
@@ -582,8 +579,6 @@ class _QuillEditorSelectionGestureDetectorBuilder
         Feedback.forLongPress(_state.context);
       }
     }
-
-    _showMagnifierIfSupported(details.globalPosition);
   }
 
   @override
@@ -602,21 +597,8 @@ class _QuillEditorSelectionGestureDetectorBuilder
         }
       }
     }
-    _hideMagnifierIfSupported();
     super.onSingleLongTapEnd(details);
   }
-
-  void _showMagnifierIfSupported(Offset positionToShow) {
-    if (magnifierSupported) {
-      editor?.showMagnifier(positionToShow);
-    }
-  }
-
-  void _hideMagnifierIfSupported() {
-    if (magnifierSupported) {
-      editor?.hideMagnifier();
-    }
-  }
 }
 
 /// Signature for the callback that reports when the user changes the selection
@@ -689,7 +671,6 @@ class RenderEditor extends RenderEditableContainerBox
   Document document;
   TextSelection selection;
   bool _hasFocus = false;
-  bool get hasFocus => _hasFocus;
   LayerLink _startHandleLayerLink;
   LayerLink _endHandleLayerLink;
 
@@ -896,28 +877,20 @@ class RenderEditor extends RenderEditableContainerBox
   }
 
   Offset? _lastTapDownPosition;
-  Offset? _lastSecondaryTapDownPosition;
-
-  Offset? get lastSecondaryTapDownPosition => _lastSecondaryTapDownPosition;
 
   // Used on Desktop (mouse and keyboard enabled platforms) as base offset
   // for extending selection, either with combination of `Shift` + Click or
   // by dragging
   TextSelection? _extendSelectionOrigin;
 
-  void handleSecondaryTapDown(TapDownDetails details) {
-    _lastTapDownPosition = details.globalPosition;
-    _lastSecondaryTapDownPosition = details.globalPosition;
-  }
-
   @override
   void handleTapDown(TapDownDetails details) {
     _lastTapDownPosition = details.globalPosition;
   }
 
   bool _isDragging = false;
 
-  void handleDragStart(TapDragStartDetails details) {
+  void handleDragStart(DragStartDetails details) {
     _isDragging = true;
 
     final newSelection = selectPositionAt(
@@ -930,7 +903,7 @@ class RenderEditor extends RenderEditableContainerBox
     _extendSelectionOrigin = newSelection;
   }
 
-  void handleDragEnd(TapDragEndDetails details) {
+  void handleDragEnd(DragEndDetails details) {
     _isDragging = false;
     onSelectionCompleted();
   }

lib/src/editor/raw_editor/config/raw_editor_config.dart

@@ -66,7 +66,6 @@ class QuillRawEditorConfig {
     this.onScribbleActivated,
     this.scribbleAreaInsets,
     this.readOnlyMouseCursor = SystemMouseCursors.text,
-    @experimental this.magnifierConfiguration,
     this.onPerformAction,
     @experimental this.customLeadingBuilder,
   });
@@ -402,11 +401,6 @@ class QuillRawEditorConfig {
   /// Optional insets for the scribble area.
   final EdgeInsets? scribbleAreaInsets;
 
-  /// This feature is currently experimental and only supported
-  /// on **Android** and **iOS**.
-  @experimental
-  final TextMagnifierConfiguration? magnifierConfiguration;
-
   /// Called when a text input action is performed.
   final void Function(TextInputAction action)? onPerformAction;
 }