Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text magnification feature for the Quill Editor #1504

Open
AdiSuresh opened this issue Nov 4, 2023 · 13 comments
Open

Text magnification feature for the Quill Editor #1504

AdiSuresh opened this issue Nov 4, 2023 · 13 comments
Labels
deferred This issue is not a current priority and will not be addressed in the near future. enhancement New feature or request minor Minimal impact or cosmetic issue. Can be resolved at a later time without affecting overall function mobile Issues or feature requests related to mobile platforms (e.g., Android and iOS). unplanned This will not be worked on

Comments

@AdiSuresh
Copy link

AdiSuresh commented Nov 4, 2023

I'm making a note-taking app using the flutter_quill package. While using the editor, I noticed that dragging the cursor cannot magnify the text.

Since I’m aware that the TextMagnifierConfiguration class is available for the TextField widget and text magnification is enabled by default, I thought there might be something similar in the QuillEditorConfigurations constructor but could not find any.

Is this feature already available or is there a workaround to make it work? It’d be more convenient for users to edit their notes by moving the cursor using the magnifier.

@singerdmx
Copy link
Owner

Yes it should be a nice feature

@EchoEllet EchoEllet self-assigned this Nov 6, 2023
@EchoEllet EchoEllet added the enhancement New feature or request label Nov 6, 2023
@molihuan
Copy link

molihuan commented Nov 7, 2023

I'm making a note taking app using the flutter_quill package. While using the editor, I noticed that the text cannot be magnified by dragging the cursor.

Since I’m aware that the TextMagnifierConfiguration class is available for the TextField widget and text magnification is enabled by default, I thought there might be something similar in the QuillEditorConfigurations constructor but could not find any.

Is this feature already available or is there a workaround to make it work? I think it’d be more convenient for users to edit their notes by moving the cursor easily using the magnifier.

I am also working on an open source note-taking app, interested in discussing related issues or sharing experiences together?

@singerdmx
Copy link
Owner

This is probably built-in function in TextField .
Just need right way to invoke it.

@singerdmx
Copy link
Owner

https://api.flutter.dev/flutter/material/TextField/magnifierConfiguration.html

@singerdmx
Copy link
Owner

I assume this is only for mobile?

@AdiSuresh
Copy link
Author

I'm making a note taking app using the flutter_quill package. While using the editor, I noticed that the text cannot be magnified by dragging the cursor.
Since I’m aware that the TextMagnifierConfiguration class is available for the TextField widget and text magnification is enabled by default, I thought there might be something similar in the QuillEditorConfigurations constructor but could not find any.
Is this feature already available or is there a workaround to make it work? I think it’d be more convenient for users to edit their notes by moving the cursor easily using the magnifier.

I am also working on an open source note-taking app, interested in discussing related issues or sharing experiences together?

Sure. I don’t mind having a look at your repo, but only if I get some time...

@AdiSuresh
Copy link
Author

I'm making a note taking app using the flutter_quill package. While using the editor, I noticed that the text cannot be magnified by dragging the cursor.
Since I’m aware that the TextMagnifierConfiguration class is available for the TextField widget and text magnification is enabled by default, I thought there might be something similar in the QuillEditorConfigurations constructor but could not find any.
Is this feature already available or is there a workaround to make it work? I think it’d be more convenient for users to edit their notes by moving the cursor easily using the magnifier.

If you have in mind any ideas about libraries or apps that implemented this feature

Feel free to share the presentation using images or videos

I’m attaching a video for reference. Many android apps either have the magnifier or the drag cursor widget (I don’t know what it’s actually called). I use Google Docs quite often and it has both:

Screenrecorder-2023-11-07-22-47-17-176.mp4

@AdiSuresh
Copy link
Author

I assume this is only for mobile?

Yeah it seems like it. Personally I think that all touchscreen enabled devices must have this feature.

@molihuan
Copy link

molihuan commented Nov 8, 2023

I'm making a note taking app using the flutter_quill package. While using the editor, I noticed that the text cannot be magnified by dragging the cursor.
Since I’m aware that the TextMagnifierConfiguration class is available for the TextField widget and text magnification is enabled by default, I thought there might be something similar in the QuillEditorConfigurations constructor but could not find any.
Is this feature already available or is there a workaround to make it work? I think it’d be more convenient for users to edit their notes by moving the cursor easily using the magnifier.

I am also working on an open source note-taking app, interested in discussing related issues or sharing experiences together?

Sure. I don’t mind having a look at your repo, but only if I get some time...

It's still on the drawing board.
link:https://github.com/molihuan/HLVideoNote
But it's Chinese. It hasn't been translated into English yet。

@EchoEllet
Copy link
Collaborator

I'm making a note taking app using the flutter_quill package. While using the editor, I noticed that the text cannot be magnified by dragging the cursor.
Since I’m aware that the TextMagnifierConfiguration class is available for the TextField widget and text magnification is enabled by default, I thought there might be something similar in the QuillEditorConfigurations constructor but could not find any.
Is this feature already available or is there a workaround to make it work? I think it’d be more convenient for users to edit their notes by moving the cursor easily using the magnifier.

If you have in mind any ideas about libraries or apps that implemented this feature
Feel free to share the presentation using images or videos

I’m attaching a video for reference. Many android apps either have the magnifier or the drag cursor widget (I don’t know what it’s actually called). I use Google Docs quite often and it has both:

Screenrecorder-2023-11-07-22-47-17-176.mp4

Thank you for sharing that. We will work on it soon.

@EchoEllet
Copy link
Collaborator

https://api.flutter.dev/flutter/material/TextField/magnifierConfiguration.html

The TextMagnifierConfiguration has MagnifierBuilder which returns a widget

typedef MagnifierBuilder = Widget? Function(
    BuildContext context,
    MagnifierController controller,
    ValueNotifier<MagnifierInfo> magnifierInfo,
);

@EchoEllet EchoEllet changed the title Text magnification feature Text magnification feature for the Quill Editor Nov 8, 2023
@xalanq
Copy link

xalanq commented Jan 19, 2024

any update?

@EchoEllet EchoEllet removed their assignment Dec 4, 2024
@EchoEllet EchoEllet reopened this Jan 21, 2025
@EchoEllet EchoEllet added unplanned This will not be worked on minor Minimal impact or cosmetic issue. Can be resolved at a later time without affecting overall function mobile Issues or feature requests related to mobile platforms (e.g., Android and iOS). deferred This issue is not a current priority and will not be addressed in the near future. labels Jan 21, 2025
@EchoEllet
Copy link
Collaborator

EchoEllet commented Jan 21, 2025

Reopened since it's reverted in #2413, we don't have plans on adding this feature back since it causes many issues, and we strongly prefer stability over adding new buggy features that are not well-executed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deferred This issue is not a current priority and will not be addressed in the near future. enhancement New feature or request minor Minimal impact or cosmetic issue. Can be resolved at a later time without affecting overall function mobile Issues or feature requests related to mobile platforms (e.g., Android and iOS). unplanned This will not be worked on
Projects
None yet
Development

No branches or pull requests

6 participants