Auto-insert attribute namespace if it's not already known

simplesamlphp · Feb 11, 2025 · df7e50e · df7e50e
1 parent c47e705
commit df7e50e
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/src/Attribute.php b/src/Attribute.php
@@ -106,6 +106,14 @@ public static function fromXML(DOMAttr $attr): static
      */
     public function toXML(DOMElement $parent): DOMElement
     {
+        if ($this->getNamespaceURI() !== null && !$parent->lookupPrefix($this->getNamespacePrefix())) {
+            $parent->setAttributeNS(
+                'http://www.w3.org/2000/xmlns/',
+                'xmlns:' . $this->getNamespacePrefix(),
+                $this->getNamespaceURI(),
+            );
+        }
+
         $parent->setAttributeNS(
             $this->getNamespaceURI(),
             !in_array($this->getNamespacePrefix(), ['', null])

diff --git a/src/DOMDocumentFactory.php b/src/DOMDocumentFactory.php
@@ -24,7 +24,7 @@ final class DOMDocumentFactory
      * @var non-negative-int
      * TODO: Add LIBXML_NO_XXE to the defaults when PHP 8.4.0 + libxml 2.13.0 become generally available
      */
-    public const DEFAULT_OPTIONS = LIBXML_COMPACT | LIBXML_NONET;
+    public const DEFAULT_OPTIONS = LIBXML_COMPACT | LIBXML_NONET | LIBXML_NSCLEAN;
 
 
     /**